fix(indexer-framework): clap requires group name #24501
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description Clap `requires` clauses refer to other flags by their field name, not how they appear as a flag. ## Test plan The `clickhouse-sui-indexer` example failed to run because of this issue, and now it runs.
amnn
requested review from
emmazzz,
evan-wall-mysten,
henryachen,
nickvikeras,
tpham-mysten and
wlmyng
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
evan-wall-mysten
approved these changes
Dec 3, 2025
| /// The framework ensures that tasked pipelines never commit checkpoints below the main | ||
| /// pipeline’s pruner watermark. Requires `--reader-interval-ms`. | ||
| #[arg(long, requires = "reader-interval-ms")] | ||
| #[arg(long, requires = "reader_interval_ms")] |
Collaborator
There was a problem hiding this comment.
Does this need unit tests or at least one that tests the proper usage?
TaskArgs::parse_from(vec!["cmd", "--task", "t", "--reader-interval-ms", "0"]);
Contributor
Author
There was a problem hiding this comment.
Yeah, it's not a bad idea -- will try it!
wlmyng
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clap
requiresclauses refer to other flags by their field name, not how they appear as a flag.Test plan
The
clickhouse-sui-indexerexample failed to run because of this issue, and now it runs.Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.